Bug 4673 - cl_aviMotionJpegQuality
Status: RESOLVED FIXED
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Video
Version: GIT MASTER
Hardware: All All
: P3 enhancement
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
Depends on:
Blocks:
 
Reported: 2010-07-04 16:53 EDT by tinkah
Modified: 2011-02-10 16:18:40 EST
2 users (show)

See Also:

Attachments
Allow jpeg avi and screenshot quality to be controled by cvars. (1.39 KB, patch)
2011-02-10 00:21 EST, Zack Middleton
Add jpeg quality cvars and add to README (2.11 KB, patch)
2011-02-10 15:41 EST, Zack Middleton

Description tinkah 2010-07-04 16:53:00 EDT 
Apparently, if SaveJPGToBuffer() call in RB_TakeVideoFrameCmd() gets an cl_aviMotionJpegQuality->integer (after the appropriate initialization) instead of a fixed 90, /video can get variable jpeg quality when cl_aviMotionJpeg in on (default).

Is there a reason this wasn't already in it?

Apparently SaveJPGToBuffer() already catered for the possibility of a variable quality (since it checked if (quality >= 85) at a point) though it gets it fixed in its only call currently.
Comment 1 tinkah 2010-07-05 08:19:17 EDT 
it can probably be done for screenshotjpeg too.
Comment 2 Thilo Schulz 2011-02-04 11:59:18 EST 
Uhh. Sorry, but, wtf?
Comment 3 Zack Middleton 2011-02-10 00:21:19 EST 
Created attachment 2590 [details]
Allow jpeg avi and screenshot quality to be controled by cvars.

Based on tinkah suggestions I added two cvars, r_aviMotionJpegQuality which controls motion jpeg avi video quality and r_screenshotJpegQuality which controls jpeg screenshot quaility.
Comment 4 Thilo Schulz 2011-02-10 14:35:01 EST 
Please make a new patch that also updates the new cvar list in the README, and I'll commit it!
Comment 5 Zack Middleton 2011-02-10 15:41:23 EST 
Created attachment 2594 [details]
Add jpeg quality cvars and add to README

Added jpeg quality control cvars to README.
Comment 6 Thilo Schulz 2011-02-10 16:18:40 EST 
thanks, applied.