Bug 4879 - Prevent teamchanges for gameplay exploit reasons
Status: RESOLVED FIXED
Alias: None
Product: Tremulous
Classification: Unclassified
Component: Misc
Version: unspecified
Hardware: All All
: P3 minor
Assignee: Tim Angus
QA Contact: Tremulous Bugs
URL:
Depends on:
Blocks:
 
Reported: 2011-01-16 17:38 EST by Chris "Lakitu7" Schwarz
Modified: 2011-01-19 16:38:16 EST
2 users (show)

See Also:


Attachments
proposed patch (3.65 KB, patch)
2011-01-16 17:39 EST, Chris "Lakitu7" Schwarz
proposed patch (3.65 KB, patch)
2011-01-16 19:02 EST, Chris "Lakitu7" Schwarz

Description Chris "Lakitu7" Schwarz 2011-01-16 17:38:59 EST
While the existing code prevents people from changing teams to get around the build timer, they still do it to get out of basi grabs, the /kill timer, and other such nonsense. 

Proposed patch prevents users from switching teams more often than every 30 seconds, unless they have the forceteamchange flag. This supersedes all the buildtimer exploit code because the max buildtimer for any building is also 30 seconds, so I removed it.
Comment 1 Chris "Lakitu7" Schwarz 2011-01-16 17:39:24 EST
Created attachment 2556 [details]
proposed patch
Comment 2 Cadynum 2011-01-16 18:29:47 EST
I sometimes join the wrong team at the start of each round. 
Does this patch take into account if you spawn or not? If it doesn't perhaps it should.
Comment 3 Chris "Lakitu7" Schwarz 2011-01-16 19:02:22 EST
Created attachment 2558 [details]
proposed patch

Re: Cadynum: It took a few minutes, I thought of a trivially easy way to allow that, so okay. With this change the limit only applies if you have been alive for at least one second during any part of the round. :)
Comment 4 Ben Millwood 2011-01-16 21:35:26 EST
I suggest that instead of disallowing rapid team changes, we simply make it unprofitable. I think if credits were awarded for someone leaving a team as if they'd died, the irritating exploits would be rendered largely useless.
Comment 5 Chris "Lakitu7" Schwarz 2011-01-19 15:27:44 EST
Committed at r2103. Benmachine was subsequently persuaded.
Comment 6 Cadynum 2011-01-19 16:38:16 EST
I agree with benmachine. While this patch is better than nothing it's not the ideal solution.