Bug 4889 - Specific border width/color for undecorated active/inactive windows
Status: RESOLVED FIXED
Alias: None
Product: Openbox
Classification: Unclassified
Component: general
Version: 3.4.11.2
Hardware: PC Linux
: P1 enhancement
Assignee: Dana Jansens
QA Contact:
URL:
Depends on:
Blocks:
 
Reported: 2011-02-02 06:31 EST by carlosjosepita
Modified: 2011-10-14 17:04:04 EDT
1 user (show)

See Also:


Attachments
Patch (5.34 KB, application/octet-stream)
2011-02-02 06:31 EST, carlosjosepita
Specific-border-width-color-for-undecorated-active-i.patch (4.81 KB, patch)
2011-10-02 22:02 EDT, carlosjosepita

Description carlosjosepita 2011-02-02 06:31:14 EST
Created attachment 2571 [details]
Patch

Decorated window borders have to cosmetically play well with titlebar, handle, grips, etc. while the concerns are different for undecorated windows: just make clearly visible the window contour and which client currently owns the focus. So color and width preferences could be different for both scenarios.

This is specially relevant when using pytyle within openbox. As far as pytyle can render its own borders one could argue that this is not openbox responsability at all. But be aware that there are issues with the pytyle approach (see http://code.google.com/p/pytyle/issues/detail?id=3).

The attached patch adds three theme options with backward compatible defaults:

undecorated.border.width
  defaults to border.width

window.active.undecorated.border.color
  defaults to window.active.border.color

window.inactive.undecorated.border.color
  defaults to window.inactive.border.color
Comment 1 Dana Jansens 2011-08-31 13:38:21 EDT
In general, I'm all for more color and look features in themes.  But I don't want the size of those decorations changing based on focus.

If you can resubmit the patch without the width stuff, against our current master branch, then I will apply that for the next release.

One other thing:
window.active.undecorated.border.color should be changed to window.undecorated.active.border.color
And similar for inactive.

Thanks.
Comment 2 carlosjosepita 2011-09-28 21:01:53 EDT
Dana, I can remove the width stuff but please take into account that the width doesn't change with focus but with decoration on/off. This is intended to play nice with pytyle: "just make clearly visible the window contour and which client currently owns the focus". Maybe the last part was misleading: the focus would be -as always- indicated by border color.
Comment 3 Dana Jansens 2011-09-29 12:52:34 EDT
Okay, I'm fine with having a different border size for undecorated windows.
Comment 4 carlosjosepita 2011-10-02 21:59:33 EDT
Updated to latest git and renamed:

window.active.undecorated.border.color ->
window.undecorated.active.border.color

window.inactive.undecorated.border.color -> 
window.undecorated.inactive.border.color

frame_focused_undecorated_border_color ->
frame_undecorated_focused_border_color

frame_unfocused_undecorated_border_color ->
frame_undecorated_unfocused_border_color

Btw, are you interested in this https://bugzilla.icculus.org/show_bug.cgi?id=4876. I could update it now that I'm again in this business.
Comment 5 carlosjosepita 2011-10-02 22:02:38 EDT
Created attachment 2989 [details]
Specific-border-width-color-for-undecorated-active-i.patch
Comment 6 Dana Jansens 2011-10-14 17:04:04 EDT
great, applied this to my work branch (with some whitespace changes).

thanks!