Bug 4894 - EasyClientName unnecessarily strcpys a buffer into itself
Status: RESOLVED FIXED
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Misc
Version: unspecified
Hardware: PC Linux
: P3 normal
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
Depends on:
Blocks:
 
Reported: 2011-02-05 13:45 EST by Simon McVittie
Modified: 2011-02-08 18:16:12 EST
1 user (show)

See Also:

Attachments
proposed patch (929 bytes, patch)
2011-02-05 13:45 EST, Simon McVittie

Description Simon McVittie 2011-02-05 13:45:42 EST 
Created attachment 2579 [details]
proposed patch

I tried running an OA server under Valgrind. Among other things, it complains that EasyClientName calls strcpy with overlapping buffers, which isn't valid; it turns out to be copying a string to the same string, which is useless at best.  See attached patch.
Comment 1 Thilo Schulz 2011-02-08 18:16:12 EST 
fixed r1882