Bug 4919 - Extra variable in missionpack ui's bind_t structure
Status: RESOLVED FIXED
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Misc
Version: GIT MASTER
Hardware: All All
: P3 trivial
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
Depends on:
Blocks:
 
Reported: 2011-03-04 02:31 EST by Zack Middleton
Modified: 2011-03-04 15:27:08 EST
1 user (show)

See Also:

Attachments
Remove unused 'int id;' from missionpack ui bind_t. (300 bytes, patch)
2011-03-04 02:31 EST, Zack Middleton

Description Zack Middleton 2011-03-04 02:31:42 EST 
Created attachment 2626 [details]
Remove unused 'int id;' from missionpack ui bind_t.

Missionpack ui has 'int id;' in its bind_t, but 'id' is unused and there is no 'id' data in g_bindings. 'id' field is skipped in g_bindings definition, so data fields after 'id' are labeled wrong. After looking at code and testing, it appears nothing should change if 'id' is removed.

If 'Controls_SetConfig(qtrue);' was placed after 'Controls_SetDefaults();' in ui_main.c it would now set default binds for controls, instead of doing nothing. Default binds in g_bindings would need changes before that should be added ioq3.
Comment 1 Thilo Schulz 2011-03-04 15:27:08 EST 
r1903