Bug 4930 - vm_powerpc_asm needs to include the header for ARRAY_LEN
Status: RESOLVED FIXED
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Platform
Version: GIT MASTER
Hardware: Macintosh Linux
: P3 normal
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
Depends on:
Blocks:
 
Reported: 2011-03-13 08:49 EDT by Simon McVittie
Modified: 2011-03-13 12:54:49 EDT
0 users

See Also:

Attachments
include vm_local.h in vm_powerpc_asm.c (813 bytes, application/x-wine-extension-patch)
2011-03-13 08:49 EDT, Simon McVittie

Description Simon McVittie 2011-03-13 08:49:17 EDT 
Created attachment 2638 [details]
include vm_local.h in vm_powerpc_asm.c

I uploaded a recent snapshot (r1921 with Debian patches) to Debian experimental, and it failed on the powerpc autobuilder:

code/qcommon/vm_powerpc_asm.c:392: warning: implicit declaration of function 'ARRAY_LEN'
code/qcommon/vm_powerpc_asm.c:392: error: initializer element is not constant

(<https://buildd.debian.org/fetch.cgi?pkg=ioquake3&arch=powerpc&ver=1.36%2Bsvn1921-1&stamp=1299807225&file=log>)

I think this just needs a header added. Patch description:

    include vm_local.h in vm_powerpc_asm.c
    
    This indirectly includes q_shared.h, which is needed for ARRAY_LEN;
    I didn't use that header directly to be consistent with the other VM
    files.
Comment 1 Ludwig Nussel 2011-03-13 12:54:49 EDT 
applied, thanks