Created attachment 2665[details]
stderr of a release build
I've recently upgraded my GCC and it seems to have a new warning -Wunused-but-set-variable
I promptly compiled ioq3 with it and it vomited a thousand of these everywhere. Attached is the compile log. I realise it's a huge pain to deal with and probably some of the warnings will be spurious, but I bet there's at least some legitimate concerns in there.
Created attachment 2666[details]
i -> latest
At least one of the warnings seems to be a genuine bug:
> code/botlib/be_ai_move.c: In function ‘BotResetLastAvoidReach’:
> code/botlib/be_ai_move.c:3512:26: warning: array subscript is above array bounds [-Warray-bounds]
Indeed, in the code in question, i will always be MAX_AVOIDREACH so the index will be out of bounds.
The attached patch makes the code do what I think it meant to do, although not being very familiar with the botlib I'm not completely sure.
Would you like to supply a patch that fixes these warnings? No reason to keep these variables included.
In the meantime, I applied the array OOB issue.
Created attachment 2665 [details] stderr of a release build I've recently upgraded my GCC and it seems to have a new warning -Wunused-but-set-variable I promptly compiled ioq3 with it and it vomited a thousand of these everywhere. Attached is the compile log. I realise it's a huge pain to deal with and probably some of the warnings will be spurious, but I bet there's at least some legitimate concerns in there.