Bug 4972 - Do use the SV_Game{Error,Print} functions
Status: RESOLVED FIXED
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Misc
Version: GIT MASTER
Hardware: All All
: P3 minor
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
Depends on:
Blocks:
 
Reported: 2011-05-03 15:13 EDT by uZu
Modified: 2011-05-04 11:20:48 EDT
1 user (show)

See Also:

Attachments
make use of the SV_Game{Error,Print} functions (368 bytes, application/x-gzip)
2011-05-03 15:13 EDT, uZu

Description uZu 2011-05-03 15:13:38 EDT 
Created attachment 2683 [details]
make use of the SV_Game{Error,Print} functions

Hello,
the functions SV_GameError() and SV_GamePrint() found at the top of the sv_game.c file are not used. I guess they were expected to be used in the switch() within the SV_GameSystemCalls() func so I made a patch doing this (a tough one, for sure ;))
Another possibility is just to remove the func from that file.
Have a nice day
Comment 1 uZu 2011-05-03 15:14:36 EDT 
diff -Nur ioquake3-1959/code/server/sv_game.c ioquake3-1959-SV_GamePrintError/code/server/sv_game.c
--- ioquake3-1959/code/server/sv_game.c	2011-05-03 20:43:15.395823771 +0200
+++ ioquake3-1959-SV_GamePrintError/code/server/sv_game.c	2011-05-03 20:52:06.035823768 +0200
@@ -300,10 +300,10 @@
 intptr_t SV_GameSystemCalls( intptr_t *args ) {
 	switch( args[0] ) {
 	case G_PRINT:
-		Com_Printf( "%s", (const char*)VMA(1) );
+		SV_GamePrint( (const char*)VMA(1) );
 		return 0;
 	case G_ERROR:
-		Com_Error( ERR_DROP, "%s", (const char*)VMA(1) );
+		SV_GameError( (const char*)VMA(1) );
 		return 0;
 	case G_MILLISECONDS:
 		return Sys_Milliseconds();
Comment 2 Thilo Schulz 2011-05-04 10:52:17 EDT 
Please submit your patches in plaintext.
Whatever, committed in r1960
Comment 3 uZu 2011-05-04 11:20:48 EDT 
(In reply to comment #2)
> Please submit your patches in plaintext.
sure

> Whatever, committed in r1960
ty