Bug 4973 - Improved STANDALONE: add default homepath
Status: RESOLVED FIXED
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Platform
Version: GIT MASTER
Hardware: All All
: P3 normal
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
Depends on:
Blocks:
 
Reported: 2011-05-03 16:01 EDT by uZu
Modified: 2011-05-04 11:40:05 EDT
1 user (show)

See Also:


Attachments
Adds HOMEPATH_NAME (default homepath) to q_shared.h (2.25 KB, patch)
2011-05-03 16:01 EDT, uZu
Adds HOMEPATH_NAME_{UNIX,WIN,MACOSX} (default homepath) to q_shared.h (2.20 KB, patch)
2011-05-04 11:16 EDT, uZu

Description uZu 2011-05-03 16:01:45 EDT
Created attachment 2684 [details]
Adds HOMEPATH_NAME (default homepath) to q_shared.h

Building with STANDALONE implies to, at least, change values in the code/qcommon/q_shared.h file AND in the code/sys/sys_{unix,win32}.c to set the product names and details. The included patch adds a "#define HOMEPATH_NAME" in the q_shared.h in order to concentrate all custom definitions in one place.
Comment 1 Thilo Schulz 2011-05-04 10:47:41 EDT
I guess the patch would be okay - I just dislike that you have it discriminate OS versions via #ifdefs - completely unnecessary.
Please use macros like:
HOMEPATH_NAME_UNIX
HOMEPATH_NAME_WIN
HOMEPATH_NAME_MACOSX
Comment 2 uZu 2011-05-04 11:16:39 EDT
Created attachment 2688 [details]
Adds HOMEPATH_NAME_{UNIX,WIN,MACOSX} (default homepath) to q_shared.h

You're right, no reason to make an OS distinction for this
Comment 3 Thilo Schulz 2011-05-04 11:40:05 EDT
Thank you! committed r1961