Bug 4994 - OpenBSD compilation fixes
Status: RESOLVED FIXED
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Platform
Version: GIT MASTER
Hardware: PC OpenBSD
: P3 normal
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
Depends on:
Blocks:
 
Reported: 2011-05-21 10:51 EDT by Jonathan Gray
Modified: 2011-06-06 11:01:47 EDT
1 user (show)

See Also:

Attachments
OpenBSD build fixes (957 bytes, patch)
2011-05-21 10:51 EDT, Jonathan Gray

Description Jonathan Gray 2011-05-21 10:51:52 EDT 
Created attachment 2718 [details]
OpenBSD build fixes

The attached diff enables non i386 OpenBSD platforms (tested on amd64/i386) and fixes include order.

Not including the following hunk found in the local OpenBSD patches for openarena which while it compiled in the end looks wrong

Index: code/client/libmumblelink.c
===================================================================
--- code/client/libmumblelink.c (revision 1997)
+++ code/client/libmumblelink.c (working copy)
@@ -101,7 +101,11 @@
                return 0;
 
        snprintf(file, sizeof (file), "/MumbleLink.%d", getuid());
+#ifdef __OpenBSD__
+       shmfd = open(file, O_RDWR, S_IRUSR | S_IWUSR);
+#else
        shmfd = shm_open(file, O_RDWR, S_IRUSR | S_IWUSR);
+#endif
        if(shmfd < 0) {
                return -1;
        }

What is the correct way of dealing with a lack of shm_open here?
Comment 1 Thilo Schulz 2011-06-06 11:01:47 EDT 
I have no idea. Yes, the call to "open" seems wrong... though I don't particularly feel inclined to do much research to accomodate this border case. Guess OpenBSD users will have to live without mumble support for the time being.

Thanks for providing the patch, committed r2008