this is the place to submit large refactoring patches, containing:
- code cleanups
- grammar corrections
- removal of unused stuff
- improvements to documentation (comments)
- etc.
I'm interested in some of these changes but not others. Copyediting comments or variable names is a waste of time and only makes patches more difficult to merge.
My inclination is nearly all of this is not worth the time, and I won't commit any of your patches that have zero effect on functionality. Code should be refactored if you have to change it anyway, otherwise you're just making old patches less likely to apply.
I committed the important parts of attachment 2737[details] at revision 2267. I did not commit the grammar/spelling fixes in comments because that is entirely unnecessary and annoying or some things that were not obviously the right thing
Attachment 2750[details] only corrects comments which would be fine if it weren't such a huge patch for nothing
Attachment 2779[details] is again a patch with a bunch of random stuff, but nothing particularly significant. I'd probably commit it if it only removed unused things
Attachment 2841[details]: in many cases changing passive voice to active voice can make a big improvement on readability, but the opposite is rarely true. Even if it made a significant improvement in the prose that is C code, I wouldn't commit it
Created attachment 2737 [details] a refactoring package (2011-05-25)Created attachment 2750 [details] refactor some bg_misc.c commentsCreated attachment 2779 [details] a refactoring package (2011-06-14)Created attachment 2841 [details] refactoring is a life