Bug 5062 - Couple of fixes for q3ui.
Status: RESOLVED FIXED
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Misc
Version: unspecified
Hardware: All All
: P3 trivial
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
Depends on:
Blocks:
 
Reported: 2011-06-30 13:39 EDT by ensiform
Modified: 2011-07-07 12:13:05 EDT
1 user (show)

See Also:


Attachments
Multiple q3ui patches listed in comments (4.78 KB, patch)
2011-06-30 13:39 EDT, ensiform
Updated patch (4.77 KB, patch)
2011-06-30 16:59 EDT, ensiform
Crosshair use spin control, spin control wraparound. (2.21 KB, patch)
2011-06-30 17:26 EDT, Zack Middleton
Merged patches, colorize flash (4.35 KB, patch)
2011-06-30 17:57 EDT, Zack Middleton
Readded line that was removed by mistake. (4.36 KB, patch)
2011-07-04 11:21 EDT, Zack Middleton

Description ensiform 2011-06-30 13:39:17 EDT
Created attachment 2802 [details]
Multiple q3ui patches listed in comments

Crosshair selection does not support left/right arrow for switching. (includes fix to support this and wrap around to min/max value)

Spin controls don't support wrapping the value from min to max. (includes fix to do so instead of buzzing)

The railgun on the controls menu when railgun is highlighted to change it's bind shows black (included in patch makes it obey color1 like cgame)
Comment 1 ensiform 2011-06-30 16:27:30 EDT
Could probably change the instance of NUM_CROSSHAIRS in ui_preferences.c on line 249 to be s->numitems so that it reads:

s->curvalue = s->numitems - 1;
Comment 2 ensiform 2011-06-30 16:59:01 EDT
Created attachment 2803 [details]
Updated patch

Made the change in the second comment and fixed a [1] that should have been [2].
Comment 3 Zack Middleton 2011-06-30 17:26:49 EDT
Created attachment 2804 [details]
Crosshair use spin control, spin control wraparound.

Have crosshair use spin control and modify spin control to wraparound when using arrow keys. Patch replaces crosshair part of Ensiform's patch.
Comment 4 Zack Middleton 2011-06-30 17:57:58 EDT
Created attachment 2805 [details]
Merged patches, colorize flash

Merged Ensiform's second patch and mine, and colorized railgun flash model.
Comment 5 Zack Middleton 2011-07-04 11:21:52 EDT
Created attachment 2807 [details]
Readded line that was removed by mistake.

Readded "pi->chat = chat;" line that was removed by mistake, pointed out by Ensiform.
Comment 6 Thilo Schulz 2011-07-07 12:13:05 EDT
applied r2066