I have in rc.xml:
...
<applications>
<application title="Mozilla Firefox"><maximized>Vertical</maximized></application>
...
When I start some programs (esp. java GUI) or starting a java applet in a web browser then Openbox crashes with SIGSEGV. 100% reproducible.
I played a bit with the source code and found a dirty fix (I really don't understand the logic here, just found a dereferenced NULL):
diff -Naur work-orig/openbox-3.5.0/openbox/client.c work/openbox-3.5.0/openbox/client.c
--- openbox/client.c 2011-08-01 22:14:58.000000000 +0200
+++ openbox/client.c 2011-10-22 14:59:56.000000000 +0200
@@ -883,7 +883,7 @@
!g_pattern_match(app->role,
strlen(self->role), self->role, NULL))
match = FALSE;
- else if (app->title &&
+ else if (app->title && self->title &&
!g_pattern_match(app->title,
strlen(self->title), self->title, NULL))
match = FALSE;
(In reply to comment #5)
> sorry, I should have said, see the patch I submitted for Bug 5412 which fixes
> this problem for me.
I applied that one and it has those issues.
Thanks for the report, figured out it was a case of a title per-app rule in this case. But the window's title wasn't set up for "fake-managing" a window to answer questions, something that Java apps make use of.
http://git.io/4vXOfQ
Thanks for the fix!
I'd completely forgotten about the issue after I stopped seeing it as a side-effect of another change I made long ago---disabling Java in all browsers in response to the repeated vulnerabilities it introduced through applets. Finally the arbitrary limit on Java update frequency (including emergency patches!) produced a positive outcome, eh? I can re-enable it to test the fix if needed, but I assume others can do that instead.
(In reply to comment #7)
> Thanks for the report, figured out it was a case of a title per-app rule in
> this case. But the window's title wasn't set up for "fake-managing" a window to
> answer questions, something that Java apps make use of.
>
> http://git.io/4vXOfQ
I applied this patch instead of mine and it does fix the issue for me. Thanks!
Oli
using ubuntu 12.04 with 3.5.0-2ubuntu2 package. Not sure if started with recently firefox updates but with FF15.0.1 all websites with java applets on them started crashing openbox. Whether using icedtea plugin or oracle's one.
openbox compiled from github/master still problem persist. Applied http://git.io/4vXOfQ patch resolved it.
This is marked RESOLVED FIXED in Version 3.5.0 but I'm running 3.5.0 now
(XUbuntu 13.04) and the problem still occurs - any Java GUI app that
I run will crash openbox.
where is the fixed version? Please release a working build
that the Ubuntu (and other) repos can use.
I have in rc.xml: ... <applications> <application title="Mozilla Firefox"><maximized>Vertical</maximized></application> ... When I start some programs (esp. java GUI) or starting a java applet in a web browser then Openbox crashes with SIGSEGV. 100% reproducible. I played a bit with the source code and found a dirty fix (I really don't understand the logic here, just found a dereferenced NULL): diff -Naur work-orig/openbox-3.5.0/openbox/client.c work/openbox-3.5.0/openbox/client.c --- openbox/client.c 2011-08-01 22:14:58.000000000 +0200 +++ openbox/client.c 2011-10-22 14:59:56.000000000 +0200 @@ -883,7 +883,7 @@ !g_pattern_match(app->role, strlen(self->role), self->role, NULL)) match = FALSE; - else if (app->title && + else if (app->title && self->title && !g_pattern_match(app->title, strlen(self->title), self->title, NULL)) match = FALSE;