Bug 5283 - Changes to the Makefile to make building standalone games easier
Status: RESOLVED FIXED
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Misc
Version: GIT MASTER
Hardware: All Linux
: P3 enhancement
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
Depends on:
Blocks:
 
Reported: 2011-10-27 15:28 EDT by JBravo
Modified: 2011-12-25 18:42:40 EST
2 users (show)

See Also:


Attachments
Patch for the Makefile (18.43 KB, patch)
2011-10-27 15:31 EDT, JBravo
Additional/different Makefile options. (35.27 KB, patch)
2011-10-27 18:23 EDT, Zack Middleton

Description JBravo 2011-10-27 15:28:26 EDT
I am on the Reaction team and we are using ioq3 as a base for our mod.  In order to build Reaction properly I need to change things like the name of the exe and the basename of the mod in the Makefile.   This leads to rather large amounts of changes in the Makefile and every time I apply fixes from ioq3 to Reaction the Makefile part always fails to apply as our Makefile is heavily changed.

With the attached patch, all I need to do is create my Makefile.local and put in 3 variables and the Makefile is almost good enough for us and all the changes I need to do in the Makefile are adding our specific .c files for compilation.

I was thinking that other people could be in our situation so I'm submitting this patch for inclusion in ioquake3.

The patch is attached.

JBravo.
Comment 1 JBravo 2011-10-27 15:31:06 EDT
Created attachment 3001 [details]
Patch for the Makefile
Comment 2 Tim Angus 2011-10-27 17:39:46 EDT
Seems reasonable. Applied in r2189.
Comment 3 Zack Middleton 2011-10-27 18:23:44 EDT
Created attachment 3002 [details]
Additional/different Makefile options.

I did the same thing for my own code bases (ioq3ztm, turtlearena), but slightly different. The attached patch adds more options for disabling building basegame, renaming missionpack, and setting cflags for basegame and missionpack. It renames the 3 variables added by the original patch to what I thought was consistent with other the variables.
Comment 4 Zack Middleton 2011-10-27 18:35:49 EDT
Reopening issue.
Comment 5 JBravo 2011-10-27 22:09:57 EDT
Yes, I like Zack's patch.   And while reading it I saw I choose the variable names poorly :)   It will certainly make my life easier :)
Comment 6 Zachary J. Slater 2011-12-25 05:00:59 EST
ZTM: Please apply your patch to svn.
Comment 7 Zack Middleton 2011-12-25 18:42:40 EST
Tim Angus applied it in r2191.