Bug 5296 - [dcompmgr] Enable VSync.
Status: RESOLVED FIXED
Alias: None
Product: Openbox
Classification: Unclassified
Component: general
Version: unspecified
Hardware: PC Linux
: P1 normal
Assignee: Dana Jansens
QA Contact:
URL:
Depends on:
Blocks:
 
Reported: 2011-11-26 09:59 EST by Alexander Chehovsky
Modified: 2012-09-30 15:39:02 EDT
1 user (show)

See Also:

Attachments
Patch (1.28 KB, patch)
2011-11-26 09:59 EST, Alexander Chehovsky
Revised patch (1.06 KB, patch)
2011-11-26 19:06 EST, Alexander Chehovsky
Revised patch (v3) (1.09 KB, patch)
2011-11-27 07:29 EST, Alexander Chehovsky

Description Alexander Chehovsky 2011-11-26 09:59:24 EST 
Created attachment 3013 [details]
Patch

To make GL compositing tear-free.
Patch attached.
Comment 1 Dana Jansens 2011-11-26 18:42:56 EST 
awesome, thanks :)
Comment 2 Mikachu 2011-11-26 18:59:05 EST 
Is there any reason you're storing an fp to the function in this struct? You're just calling it right away from the same place and never again anyway?
Comment 3 Alexander Chehovsky 2011-11-26 19:06:31 EST 
Created attachment 3014 [details]
Revised patch

Indeed, let's not store it in struct. Attached revised patch.
Comment 4 Mikachu 2011-11-26 19:19:08 EST 
We should also probably check that the returned pointer isn't NULL, in case the sync extension is not available :). (I don't know opengl that well, maybe it's always available).
Comment 5 Alexander Chehovsky 2011-11-27 07:29:14 EST 
Created attachment 3015 [details]
Revised patch (v3)

Added a NULL check.
Actually, this extension is really widely available, but just to be safe.
Comment 6 Dana Jansens 2012-09-30 15:39:02 EDT 
Thanks, commited it.