Bug 5312 - 20% fps regression introduced in SVN 2103
Status: RESOLVED FIXED
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Video
Version: GIT MASTER
Hardware: PC Linux
: P3 major
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
Depends on:
Blocks:
 
Reported: 2011-12-11 16:26 EST by quake3fan
Modified: 2012-05-04 12:01:46 EDT
4 users (show)

See Also:



Description quake3fan 2011-12-11 16:26:41 EST
By bisecting I've found an fps regression introduced in SVN revision 2103 that still exists in revision 2210. Measuring with a custom q3 demo shows:

revision 2102: 140.6 fps
revision 2103: 111.7 fps
revision 2210: 111.6 fps
revision 2210 + "changes between r2103 and r2102 reverted": 140.5 fps

OS: Debian testing/unstable, amd64.
OpenGL renderer string: GeForce 8200/PCI/SSE2
OpenGL version string: 3.3.0 NVIDIA 290.10
Comment 1 Simon McVittie 2011-12-12 04:08:59 EST
FWIW, the only change in r2103 was to fix Bug #5097.
Comment 2 quake3fan 2011-12-13 18:52:02 EST
Yes, that's true. All I did to increase fps in r2210 by 25% from 111.6 to 140.5 was to revert this patch:

https://bugzilla.icculus.org/attachment.cgi?id=2864&action=edit

And so far I haven't seen any of the problems described in Bug #5097. Maybe they appear on IRIX only. Then on all the other architectures but at least on x86_64 things should be handled differently to increase fps IMHO.
Comment 3 Zack Middleton 2012-03-30 16:38:30 EDT
I have fps decrease as well.

//r_fullscreen 0; r_mode 4; vid_restart; timedemo 1; demo four
58.6 fps using r2231, 67.5 fps with r2103 reverted.

//r_fullscreen 1; r_mode -1; r_customwidth 1920; r_customheight 1080; vid_restart; timedemo 1; demo four
24.9 fps using r2231, 31.1 fps with r2103 reverted.

Ubuntu 11.10 amd64
GL_RENDERER: GeForce 8200/PCI/SSE2
GL_VERSION: 3.3.0 NVIDIA 280.13
Comment 4 gimhael 2012-04-16 13:23:50 EDT
I haven't checked if this is the case here, but the NVidia driver disables CSAA and switches to slower(?) MSAA when you call glClear to clear only a part of the buffer (glClear is affected by the scissor rectangle).

The driver logs a message to the GL_ARB_debug_output log when CSAA is deactivated, but creating a debug GL context is difficult in SDL 1.2.
Comment 5 Thilo Schulz 2012-05-04 12:01:46 EDT
reverted the patch from r2103, should be fixed now.