Bug 5408 - Patch that add's r_mode desktop resolution detection
Status: RESOLVED FIXED
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Video
Version: GIT MASTER
Hardware: All All
: P3 enhancement
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
Depends on:
Blocks:
 
Reported: 2012-01-10 15:18 EST by JBravo
Modified: 2012-08-27 10:57:32 EDT
3 users (show)

See Also:


Attachments
Desktop resolution patch (1.08 KB, patch)
2012-01-10 15:19 EST, JBravo

Description JBravo 2012-01-10 15:18:16 EST
When starting ioq3 for the first time the default resolution is always set to some lowres default which can be quite annoying, forcing the user to go fiddle with the system settings in order to get something usable.

This patch makes ioq3 automatically start up using the same resolution as the desktop is using when r_mode is set to -2

If this patch is accepted, it could be wise to have r_mode default to -2

Patch was written for ReactionQuake 3 by Makro (Andrei Drexler)
Comment 1 JBravo 2012-01-10 15:19:38 EST
Created attachment 3068 [details]
Desktop resolution patch
Comment 2 Zack Middleton 2012-01-10 16:35:22 EST
I added a similar r_mode -2 for using desktop resolution to ioq3 in r2145, but Timbo didn't seem to want it. It was removed in r2147.

Turtle Arena has r_mode -2 as default for reasons listed above.
Comment 3 JBravo 2012-01-29 10:47:50 EST
r_mode can still default to what ever it defaults to now and then this patch has no effect on the current codebase, except giving users/modders the choice of an easy, problem free way to handle resolution issues.
Comment 4 JBravo 2012-02-26 09:59:39 EST
So I'm going to go out on a limb here and assume we are not interested in a patch like this? :)
Comment 5 Tim Angus 2012-02-27 14:25:03 EST
It was setting the default that I was wary about. It's all very well saying "surely nobody these days still has a computer that can't do display sized OpenGL windows!", but past experience tends to indicate that whenever you fuck with something along those lines, somebody, somewhere has a problem with it. So it's best to stick with the status quo unless there is a good reason not to. This patch looks fine though, as it doesn't change the default behaviour.
Comment 6 Thilo Schulz 2012-07-01 12:33:39 EDT
Well, Zack: Why not reimplement your work from r2145, and just make sure r_mode -2 is not default?
I agree with Timbo that we should leave the default at 640x480 untouched, but add r_mode -2 as an option to users.
Obviously, it should be documented in the README as well.
Comment 7 Zack Middleton 2012-08-27 10:57:32 EDT
Added r_mode -2 in r2311.