Bug 5918 - Sys_DefaultHomePath doesn't free DLL on all code paths
Status: RESOLVED FIXED
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Misc
Version: GIT MASTER
Hardware: PC Windows NT
: P3 trivial
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
Depends on:
Blocks:
 
Reported: 2013-04-09 14:36 EDT by Dion Williams
Modified: 2013-04-09 16:43:25 EDT
1 user (show)

See Also:

Attachments
[PATCH] Fix Sys_DefaultHomePath not calling FreeLibrary on all code paths in code/sys/sys_win32.c (1.30 KB, application/octet-stream)
2013-04-09 14:36 EDT, Dion Williams
Fix Sys_DefaultHomePath not calling FreeLibrary on all code paths in code/sys/sys_win32.c (1.30 KB, patch)
2013-04-09 14:39 EDT, Dion Williams

Description Dion Williams 2013-04-09 14:36:02 EDT 
Created attachment 3340 [details]
[PATCH] Fix Sys_DefaultHomePath not calling FreeLibrary on all code paths in code/sys/sys_win32.c

In code/sys/sys_win32.c (Line 127), Sys_DefaultHomePath doesn't call FreeLibrary and can lead to "shfolder.dll" not being freed.

A patch file to fix the defect is attached to this issue.
Comment 1 Dion Williams 2013-04-09 14:39:59 EDT 
Created attachment 3341 [details]
Fix Sys_DefaultHomePath not calling FreeLibrary on all code paths in code/sys/sys_win32.c

Oops, didn't make the attachment marked as a patch
Comment 2 Tim Angus 2013-04-09 16:43:25 EDT 
Committed in 230af8c9e97b00bfea43890885301ae2538360df.