In function find_uid_gid, OB enumerates all groups on the system. This is very bad from a performance perspective, especially if you have many groups. It should use getgroups() or similar instead.
Created attachment 3550[details]
Replace getgrent with getgroups.
Our university moved to user private groups some time ago. Openbox startup took several minutes to iterate through all groups. The proposed patch reduces the startup time down to a few seconds again.
Hey Dana
Is there any chance this patch gets included in the next Openbox release? In institutions with large number of LDAP groups Openbox is not really usable right now...
Cheers
Simon
I've added this patch (changed maininc to gboolean) in my git. Googling around a bit suggests this is mostly a bug in ldap but the patch seems reasonable either way.
Created attachment 3550 [details] Replace getgrent with getgroups. Our university moved to user private groups some time ago. Openbox startup took several minutes to iterate through all groups. The proposed patch reduces the startup time down to a few seconds again.