Bug 6065 - toggled_hover/toggled_pressed bitmaps ignored
Status: RESOLVED FIXED
Alias: None
Product: Openbox
Classification: Unclassified
Component: general
Version: 3.5.2
Hardware: PC Linux
: P3 normal
Assignee: Dana Jansens
QA Contact:
URL:
Depends on:
Blocks:
 
Reported: 2013-11-19 12:37 EST by Norbert Zeh
Modified: 2015-03-09 15:18:22 EDT
1 user (show)

See Also:


Description Norbert Zeh 2013-11-19 12:37:34 EST 
I just noticed that providing any of the *_toggled_pressed.xbm and *_toggled_hover.xbm files in a theme has no effect, i.e., no matter what these files contain, a toggled button uses the standard *_toggled.xbm bitmap when hovering over or pressing the button.  I had a quick look at the source code, also on github, and I think I found the culprit: After reading in these bitmaps, they are reset to the *_toggled.xbm bitmaps in lines 553-566 of theme.c.
Comment 1 Mikachu 2014-11-05 04:53:53 EST 
Yes, your conclusion appears to be correct. I have deleted the offending lines in git. Thanks!
Comment 2 Dana Jansens 2015-03-09 15:18:22 EDT 
Commit pushed to master at https://github.com/danakj/openbox

https://github.com/danakj/openbox/commit/f1f5610cca8511be3bd03198f49a6a4e9fc15314
Remove wrong code from button mask loading code, bug 6065

The READ_MASK_COPY macro already uses these exact fallbacks, so these
lines just overwrote the custom bitmaps with the default fallback bitmaps.