Created attachment 3510[details]
keybind_menu.patch
Add the "key" property to the (sub)menu definition that allow to define the hotkey for ShowMenu action.
Exampe:
menu.xml
<menu id="desktop-app-menu"
label="Applications"
execute="xdg_menu --format openbox3-pipe"
key="W-a"
</menu>
This is equivalent of
menu.xml
<menu id="desktop-app-menu"
label="Applications"
execute="xdg_menu --format openbox3-pipe"
</menu>
rc.xml
<keybind key="W-a">
<action name="ShowMenu">
<menu> desktop-app-menu </menu>
</action>
</keybind>
This and your other patch save a little bit of time configurating maybe, but it's a big layering violation that I think just end up making things more complicated, more places where you have to look to find a keybind etc.
It is very rare that a user command should be called only with a key, but not through a menu. Therefore, there is only one place where you need to look for the definition of a key - this is the menu.xml. And, most importantly, there is only one place where you need to look for the definition of the team itself - menu.xml.
Copypast-style is very bad. This is the risk of problems when making corrections.
Created attachment 3510 [details] keybind_menu.patch Add the "key" property to the (sub)menu definition that allow to define the hotkey for ShowMenu action. Exampe: menu.xml <menu id="desktop-app-menu" label="Applications" execute="xdg_menu --format openbox3-pipe" key="W-a" </menu> This is equivalent of menu.xml <menu id="desktop-app-menu" label="Applications" execute="xdg_menu --format openbox3-pipe" </menu> rc.xml <keybind key="W-a"> <action name="ShowMenu"> <menu> desktop-app-menu </menu> </action> </keybind>Created attachment 3522 [details] keybind_menu2.patch adapted to the current state of the "master" branch