Bug 2792 - Spec camera jumping to next player when the current one dies
Status: RESOLVED FIXED
Alias: None
Product: Tremulous
Classification: Unclassified
Component: Misc
Version: unspecified
Hardware: PC All
: P2 enhancement
Assignee: Tremulous Bugs
QA Contact:
URL:
: 3039
Depends on:
Blocks:
 
Reported: 2006-07-25 00:48 EDT by rasz
Modified: 2009-10-05 01:12:38 EDT
1 user (show)

See Also:


Attachments
Patch to enable the functionality as a user option (5.65 KB, patch)
2007-02-26 18:09 EST, Chris "Lakitu7" Schwarz
Patch to enable the functionality as a user option (5.24 KB, patch)
2007-04-26 18:49 EDT, Chris "Lakitu7" Schwarz

Description rasz 2006-07-25 00:48:49 EDT
Spec camera jumping to next player when the current one dies .. IMO should stay at the choosen one
Comment 1 Tim Angus 2006-07-28 04:18:18 EDT
The existing functionality is fine .. IMO
Comment 2 rasz 2006-07-28 14:28:47 EDT
You mean you dont want to fix it, or you like how it is? Because majority of people spec one specific person, and now its constant mouse wheel action every death of that specific person :(. 
Maybe add "cl_specfollowssingle" or something? I can write a patch for that if you would be willing to include it.
Comment 3 Tim Angus 2006-07-28 14:46:45 EDT
I like it how it is, but an option to enable this functionality would be fine. 

Please do not reopen bugs because you disagree with me, I'm closing it again now. If and when you have a tested patch you can reopen this, as it stands it's neither a bug nor a patch submission.
Comment 4 M. Kristall 2007-02-26 17:51:00 EST
*** Bug 3039 has been marked as a duplicate of this bug. ***
Comment 5 Chris "Lakitu7" Schwarz 2007-02-26 18:09:09 EST
Created attachment 1275 [details]
Patch to enable the functionality as a user option

Thanks to R1CH, Kevlarman, and vcxzet. 

Sorry, I did not know non-devs could reopen bugs.
Comment 6 M. Kristall 2007-02-26 22:09:31 EST
     // can't follow another spectator
-    if( ent->client->pers.teamSelection != PTE_NONE )
+    if( level.clients[ i ].pers.teamSelection == PTE_NONE)
       return;

Oops, that's my fault (bug 2924). Funny I didn't notice it when I was testing that (and that no one else did).
Comment 7 Chris "Lakitu7" Schwarz 2007-04-26 18:49:36 EDT
Created attachment 1321 [details]
Patch to enable the functionality as a user option

R905 committed one hunk of this patch, so I remade it with that removed so it would apply cleanly.
Typo fix from Undeference.
Comment 8 Tim Angus 2007-09-20 09:57:52 EDT
How much testing has this had? Assuming it is well tested and a UI option is added this should be committed.
Comment 9 Ben Millwood 2007-09-20 12:11:06 EDT
The stickyspec patch has been in most unofficial game.qvm code and received a lot of server-side testing. However, this is without a UI option and indeed probably without any kind of configuring at all, since it it doesn't seem worthwhile to include the toggle when very few players would understand how to operate it.
So my guess is a slightly simplified version of this patch is well tested enough, and what remains (adding and testing for the cvar) is trivial enough not to need much testing at all.
Comment 10 Chris "Lakitu7" Schwarz 2009-10-05 01:12:38 EDT
This (reimplemented, and with many other things) was recently merged.