Bug 2924 - /follow improvements
Status: RESOLVED FIXED
Alias: None
Product: Tremulous
Classification: Unclassified
Component: Misc
Version: unspecified
Hardware: PC Linux
: P2 enhancement
Assignee: Tim Angus
QA Contact:
URL:
Depends on:
Blocks:
 
Reported: 2006-11-17 07:39 EST by M. Kristall
Modified: 2007-03-02 21:37:43 EST
0 users

See Also:

Attachments
/follow (2.19 KB, patch)
2006-11-17 07:40 EST, M. Kristall
/follow (2.26 KB, patch)
2006-11-23 22:08 EST, M. Kristall
/follow (2.21 KB, patch)
2006-11-23 22:14 EST, M. Kristall

Description M. Kristall 2006-11-17 07:39:42 EST 
No longer requires entering a full name.
The current implementation of /follow does nothing if you are currently following someone and you try to follow someone else. This allows you to follow the new person.

(Also removes a few messages that might confuse people and aren't all that useful anyway.)
Comment 1 M. Kristall 2006-11-17 07:40:18 EST 
Created attachment 1158 [details]
/follow
Comment 2 M. Kristall 2006-11-23 22:08:52 EST 
Created attachment 1163 [details]
/follow

    if( level.clients[ i ].pers.teamSelection == TEAM_SPECTATOR )
like that will happen... well, that was a little silly. this one makes a bit more sense :-)
Comment 3 M. Kristall 2006-11-23 22:14:56 EST 
Created attachment 1164 [details]
/follow

eh, might as well fix the comment while I'm at it
Comment 4 Tony J. White 2006-12-04 02:04:27 EST 
I like the idea of adding partial name match to /follow, running /follow with no paramaters when you are currently following should stop following not move to the next player otherwise there's no way to stop.  There are already commands for moving to the next player (/follownext and /followprev).
Comment 5 M. Kristall 2006-12-04 17:49:22 EST 
(In reply to comment #4)
> I like the idea of adding partial name match to /follow, running /follow with
> no paramaters when you are currently following should stop following not move
> to the next player otherwise there's no way to stop.  There are already
> commands for moving to the next player (/follownext and /followprev).
> 

Heh, you scared me there, making me think I broke something. /follow can still be used to toggle :-)
Comment 6 Tony J. White 2006-12-12 11:55:03 EST 
(In reply to comment #5)
> (In reply to comment #4)
> > I like the idea of adding partial name match to /follow, running /follow with
> > no paramaters when you are currently following should stop following not move
> > to the next player otherwise there's no way to stop.  There are already
> > commands for moving to the next player (/follownext and /followprev).
> > 
> 
> Heh, you scared me there, making me think I broke something. /follow can still
> be used to toggle :-)

My mistake.  Thanks, I've committed this at revision 869
Comment 7 M. Kristall 2007-02-26 22:14:44 EST 
Oops, I guess I broke follow slightly, but no one noticed. This is copied from attachment 1275 [details] for bug 2792:

Index: src/game/g_cmds.c
===================================================================
--- src/game/g_cmds.c	(revision 895)
+++ src/game/g_cmds.c	(working copy)
@@ -2524,7 +2524,7 @@
       return;
 
     // can't follow another spectator
-    if( ent->client->pers.teamSelection != PTE_NONE )
+    if( level.clients[ i ].pers.teamSelection == PTE_NONE)
       return;
 
     ent->client->sess.spectatorState = SPECTATOR_FOLLOW;
Comment 8 Tony J. White 2007-03-02 21:37:43 EST 
fixed at revision 905