Bug 2850 - Openbox gives black backgrounds to windows using the new 'rgba' or 'argb' visual
Status: CLOSED FIXED
Alias: None
Product: Openbox
Classification: Unclassified
Component: general
Version: unspecified
Hardware: PC Linux
: P2 normal
Assignee: Dana Jansens
QA Contact:
URL:
Depends on:
Blocks: 2060
 
Reported: 2006-08-25 14:29 EDT by Javeed Shaikh
Modified: 2007-03-18 11:35:18 EDT
2 users (show)

See Also:

Attachments
A working patch (5.11 KB, patch)
2006-08-25 14:30 EDT, Javeed Shaikh
Better patch, fixes a bug with previous version (5.28 KB, patch)
2006-08-25 20:03 EDT, Javeed Shaikh
Additional patch to fix colormap issues (619 bytes, patch)
2006-09-12 11:21 EDT, Tilman Sauerbeck

Description Javeed Shaikh 2006-08-25 14:29:43 EDT 
Transparency for applications using the new 'rgba' or 'argb' visual (added by a composite manager such as xcompmgr) does not work in openbox. The reason for this is that openbox's container windows are not using this visual for apps that do use it.
Comment 1 Javeed Shaikh 2006-08-25 14:30:40 EDT 
Created attachment 1034 [details]
A working patch
Comment 2 Javeed Shaikh 2006-08-25 20:03:13 EDT 
Created attachment 1036 [details]
Better patch, fixes a bug with previous version

I had neglected to test the previous patch with windows with borders. They were broken horribly. This fixes it.
Comment 3 Tilman Sauerbeck 2006-09-12 11:21:37 EDT 
Created attachment 1072 [details]
Additional patch to fix colormap issues

This patch applies on top of attachment 1036 [details].

Some clients set their attrib.colormap to an invalid value, and we cannot find out whether it's invalid or not, AFAIK.
So create the ARGB colormap on our own. Note that this probably leaks!
Comment 4 Tilman Sauerbeck 2006-11-20 12:55:52 EST 
*** Bug 2060 has been marked as a duplicate of this bug. ***
Comment 5 Tilman Sauerbeck 2006-12-10 09:12:32 EST 
That latest patch doesn't seem to leak btw (tested with xrestop).

What's needed to do until the patch can go in?
Comment 6 Dana Jansens 2007-03-02 01:02:02 EST 
thank you for the patches

i used them to implement this, and they were extremely helpful.  this is now fixed in svn.