Bug 3414 - Overlapping strings with strcpy
Status: RESOLVED FIXED
Alias: None
Product: ioquake3
Classification: Unclassified
Component: Misc
Version: GIT MASTER
Hardware: PC Linux
: P3 minor
Assignee: Zachary J. Slater
QA Contact: ioquake3 bugzilla mailing list
URL:
: 5213
Depends on:
Blocks:
 
Reported: 2007-11-11 10:03 EST by Jacques Boscq
Modified: 2011-09-01 09:09:55 EDT
1 user (show)

See Also:


Description Jacques Boscq 2007-11-11 10:03:33 EST 
in qcommon/q_shared.c function Info_RemoveKey line 1147 it would be better to use memmove instead of "strcpy (start, s);" because as said in the manual page of strcpy : "The  strings  may  not overlap".
Comment 1 Tim Angus 2007-11-11 10:49:48 EST 
*** Bug 3416 has been marked as a duplicate of this bug. ***
Comment 2 Thilo Schulz 2008-03-25 18:06:22 EDT 
agreed.
Comment 3 Jacques Boscq 2008-03-26 14:34:50 EDT 
No this is not a duplicate. The bug is still in the SVN.
Comment 4 Tim Angus 2008-03-26 15:42:19 EDT 
Revision 1280 made the following change. Is this not what you think is being tracked here?

Modified: trunk/code/qcommon/q_shared.c
===================================================================
--- trunk/code/qcommon/q_shared.c	2008-03-25 21:59:31 UTC (rev 1279)
+++ trunk/code/qcommon/q_shared.c	2008-03-25 22:06:08 UTC (rev 1280)
@@ -1143,7 +1143,8 @@
 
 		if (!strcmp (key, pkey) )
 		{
-			strcpy (start, s);	// remove this part
+			memmove(start, s, strlen(s) + 1); // remove this part
+			
 			return;
 		}
Comment 5 Jacques Boscq 2008-03-26 21:30:12 EDT 
My apologize, I wasn't checking the right SVN project (as the code of quake3 is imported in the tremulous one).
Comment 6 Jacques Boscq 2008-03-26 21:30:53 EDT 
Close the bug.
Comment 7 Thilo Schulz 2011-09-01 09:09:55 EDT 
*** Bug 5213 has been marked as a duplicate of this bug. ***